Skip to content

Fix file removal from clayer.yml#112

Merged
brondani merged 4 commits into
mainfrom
fix/110
Mar 24, 2026
Merged

Fix file removal from clayer.yml#112
brondani merged 4 commits into
mainfrom
fix/110

Conversation

@edriouk
Copy link
Copy Markdown
Collaborator

@edriouk edriouk commented Mar 24, 2026

Fixes

Changes

  • add 'layerUri' attribute to file items if they come from clayer.yml

Screenshots

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@edriouk edriouk requested a review from Copilot March 24, 2026 15:41
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 24, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA a155e1c.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #110 by ensuring file nodes originating from .clayer.yml carry sufficient context (layerUri) for layer-specific actions (e.g., removing a file entry from the layer YAML) in the Solution Outline tree.

Changes:

  • Extend context-menu attribute assignment to optionally set layerUri when items come from a layer (topTag === 'layer').
  • Thread the YAML “top tag” context from group construction into file-node construction.
  • Add a topTag field to FileItemBuilder so file nodes can set layerUri when appropriate.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/views/solution-outline/tree-structure/solution-outline-utils.ts Updates setContextMenuAttributes to accept topTag and set layerUri for layer-derived items.
src/views/solution-outline/tree-structure/solution-outline-project-items.ts Computes/passes topTag through group creation so file nodes can be tagged as layer vs project.
src/views/solution-outline/tree-structure/solution-outline-file-item.ts Adds topTag to FileItemBuilder and passes it into setContextMenuAttributes for file nodes.

Comment thread src/views/solution-outline/tree-structure/solution-outline-utils.ts Outdated
Comment thread src/views/solution-outline/tree-structure/solution-outline-utils.ts
edriouk and others added 3 commits March 24, 2026 16:47
@qltysh
Copy link
Copy Markdown

qltysh Bot commented Mar 24, 2026

Qlty

Coverage Impact

This PR will not change total coverage.

Modified Files with Diff Coverage (3)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
.../solution-outline/tree-structure/solution-outline-file-item.ts100.0%
Coverage rating: B Coverage rating: B
...ution-outline/tree-structure/solution-outline-project-items.ts100.0%
Coverage rating: C Coverage rating: C
...iews/solution-outline/tree-structure/solution-outline-utils.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copy link
Copy Markdown
Collaborator

@brondani brondani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brondani brondani merged commit 0cad6d1 into main Mar 24, 2026
12 checks passed
@brondani brondani deleted the fix/110 branch March 24, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants